Fix parallelization problems in noise estimation #728
Merged
+515
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with 8 or 16 processes per group: * When duplicating an observation, also duplicate per-detector flags. * When redistributing an observation, reset per-detector flags before setting. * Make the common mode removal an option (default True) prior to noise estimation. This is useful if the data has already had the common mode removed prior to this operator. * When high-pass filtering data that is distributed by time slices there may be some chunks that are fully flagged. This should not be an error. Instead, the flagged timestream is set to zero. * When communicating overlaps, ensure that the span used (lagmax + half_average) is less than the number of samples.
tskisner
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noise estimation code struggled with observations composed of a number of short intervals, especially when
lagmaxwas much longer than individual window.Furthermore, the data redistribution that is used to allow arbitrary crosscorrelators to be evaluated was affecting the results.
This PR addresses both of those concerns. Furthermore, it removes the unnecessary detrending step what was redundant with the highpass filter already being applied.
Finally, noise estimation is now performed independently in each interval. Earlier, the entire observation was analyzed together with the gaps between intervals simply flagged. This way there is no risk of sample pairs spanning two intervals.